nvazquez commented on code in PR #7915:
URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307586265
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java:
##########
@@ -65,6 +66,7 @@
@Component
public class LdapManagerImpl extends ComponentLifecycleBase implements
LdapManager, LdapValidator {
private static final Logger LOGGER =
Logger.getLogger(LdapManagerImpl.class.getName());
+ public static final String REMOVING_LDAP_LINK_ON_DOMAIN = "Removing link
between LDAP: %s - type: %s and account: %s on domain: %s";
Review Comment:
So far it has two usages, IMO its easier to invoke and maintain a method
which accepts the expected parameters for this string than leaving it open ended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
