gpordeus opened a new pull request, #7938:
URL: https://github.com/apache/cloudstack/pull/7938

   ### Description
   
   The API call `listSystemVMs` does not return the VM's service offering like 
`listVirtualMachines` does and, as such, the system VM page in the UI doesn't 
have that information like a user VM page has. This PR adds the fields 
`serviceOfferingId` and `serviceOfferingName` to the `SystemVmResponse` class.
   
   It also changes the link to the offering in the VR page from 
`client/#/computeoffering/<uuid>?issystem=true` to 
`/client/#/systemoffering/<uuid>` for consistency (since it was the only place 
with such a way to access the system offering).
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   ### How Has This Been Tested?
   I accessed the SSVM and CPVM pages in the UI and saw the field "Compute 
offering" with the name and link to their respective offerings. If the offering 
does not exist, it returns 404 in the same way a missing template does.
   
   On the VR page, the link to its offering now redirects to the same page as 
if you had gone through Service Offerings -> System offerings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to