harikrishna-patnala commented on code in PR #7954:
URL: https://github.com/apache/cloudstack/pull/7954#discussion_r1322388068
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java:
##########
@@ -129,9 +129,8 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
}
}
} else {
- // for user-VM, use E1000 as default
if (nicDeviceType == null) {
- details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
Review Comment:
This looks good @GaOrtiga. Do we also need to use this setting in case of an
Invalid NIC device type (in catch() in else case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
