shwstppr commented on code in PR #7873:
URL: https://github.com/apache/cloudstack/pull/7873#discussion_r1324230458
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -4451,6 +4466,172 @@ public List<RouterHealthCheckResultResponse>
listRouterHealthChecks(GetRouterHea
return
responseGenerator.createHealthCheckResponse(_routerDao.findById(routerId),
result);
}
+ @Override
+ public ListResponse<SnapshotResponse> listSnapshots(ListSnapshotsCmd cmd) {
+ Pair<List<SnapshotJoinVO>, Integer> result =
searchForSnapshotsInternal(cmd);
+ ListResponse<SnapshotResponse> response = new ListResponse<>();
+
+ ResponseView respView = ResponseView.Full;
Review Comment:
fixed
##########
api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java:
##########
@@ -65,6 +62,13 @@ public class ListSnapshotsCmd extends
BaseListTaggedResourcesCmd {
@Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, description = "list snapshots by zone id")
private Long zoneId;
+ @Parameter(name = ApiConstants.SHOW_UNIQUE, type = CommandType.BOOLEAN,
description = "If set to false, list templates across zones and their
storages", since = "4.19.0")
+ private Boolean showUnique;
+
+ @Parameter(name = ApiConstants.LOCATION_TYPE, type = CommandType.STRING,
description = "list snapshots by location type. Used only when
showunique=false." +
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
