[GitHub] [cloudstack] mlsorensen commented on a diff in pull request #7963: Trigger out of band VM state update via libvirt event when VM stops

[via GitHub]

mlsorensen commented on code in PR #7963:
URL: https://github.com/apache/cloudstack/pull/7963#discussion_r1328913605


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3590,9 +3603,60 @@ private StartupStorageCommand 
createLocalStoragePool(String localStoragePath, St
         } catch (final CloudRuntimeException e) {
             s_logger.debug("Unable to initialize local storage pool: " + e);
         }
+        setupLibvirtEventListener();
         return sscmd;
     }
 
+    private void setupLibvirtEventListener() {

Review Comment:
   Done, avoided functional programming of the event handling.



##########
core/src/main/java/com/cloud/resource/AgentStatusUpdater.java:
##########
@@ -0,0 +1,5 @@
+package com.cloud.resource;
+
+public interface AgentStatusUpdater {

Review Comment:
   done



##########
core/src/main/java/com/cloud/resource/ResourceStatusUpdater.java:
##########
@@ -0,0 +1,11 @@
+package com.cloud.resource;

Review Comment:
   done



##########
core/src/main/java/com/cloud/resource/AgentStatusUpdater.java:
##########
@@ -0,0 +1,5 @@
+package com.cloud.resource;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org