Pearl1594 commented on code in PR #7645:
URL: https://github.com/apache/cloudstack/pull/7645#discussion_r1334335290
##########
api/src/test/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmdTest.java:
##########
@@ -71,12 +82,9 @@ public void validateCidrsTestValidCidrs(){
Mockito.verify(networkServiceMock).getNetwork(networkIdMock);
Mockito.verify(networkMock).getCidr();
- PowerMockito.verifyStatic(NetUtils.class, Mockito.times(2));
- NetUtils.isValidIp4Cidr(cidrMock);
- NetUtils.isValidIp6Cidr(cidrMock);
-
- PowerMockito.verifyStatic(NetUtils.class);
- NetUtils.isNetworkAWithinNetworkB(cidrMock,cidrMock);
+ netUtilsMocked.verify(() -> NetUtils.isValidIp4Cidr(cidrMock),
Mockito.times(2));
+ netUtilsMocked.verify(() -> NetUtils.isValidIp6Cidr(cidrMock),
Mockito.never());
Review Comment:
Correct me if I'm wrong, but doesn't this mean isValidIp6Cidr is never
called? But in the powerMockito equivalent code, isn't it invoked atleast once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
