GutoVeronezi commented on PR #7134:
URL: https://github.com/apache/cloudstack/pull/7134#issuecomment-1745674462
> @GutoVeronezi @JoaoJandre , the last time @Pavan-Nambi returned to this
was in January. Will this be harmful or can it be improved by some small
changes and merged? cc @shwstppr
@DaanHoogland I think the approach used here could cause some problems,
especially the possible infinite loop that can be caused by the following block:
```java
while (!pswd.matches(passwordComplexity)) {
pswd= PasswordGenerator.generateRandomPassword(passwordLength);
}
```
I agree with @JoaoJandre on his comment
https://github.com/apache/cloudstack/issues/6861#issuecomment-1419337976.
However, if we go with the feature, we should guide @Pavan-Nambi (if they are
willing to do it) on a better approach for addressing the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
