mlsorensen commented on code in PR #8033:
URL: https://github.com/apache/cloudstack/pull/8033#discussion_r1346190709
##########
pom.xml:
##########
@@ -154,7 +154,7 @@
<cs.jaxws.version>2.3.2-1</cs.jaxws.version>
<cs.jersey-client.version>2.26</cs.jersey-client.version>
<cs.jetty.version>9.4.51.v20230217</cs.jetty.version>
-
<cs.jetty-maven-plugin.version>9.4.27.v20200227</cs.jetty-maven-plugin.version>
+
<cs.jetty-maven-plugin.version>9.4.51.v20230217</cs.jetty-maven-plugin.version>
Review Comment:
Ok I think maybe I found the issue @rohityadavcloud. Newer
jetty-maven-plugin versions add the pom dependencies to classpath
automatically, with older jetty we have defined `extraClasspath` and add a
built cloud-client-ui.jar location. This results in a lot of duplicate classes
discovered. Also notice that due to using the pom dependencies for building
classpath, without specifying `-Psimulator` the jetty:run doesn't have
simulator available which breaks the simulator CI build.
We can add explicit simulator dependency for the jetty-maven-plugin, or we
can add `-Psimulator` to the CI (but I don't know how to do the latter).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
