harikrishna-patnala commented on code in PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#discussion_r1349950583
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1313,8 +1313,8 @@ protected void setupMemoryBalloonStatsPeriod(Connect
conn) {
}
s_logger.debug(String.format("The memory balloon stats period
[%s] has been set successfully for the VM (Libvirt Domain) with ID [%s] and
name [%s].",
currentVmBalloonStatsPeriod, vmId, dm.getName()));
- } catch (final LibvirtException e) {
- s_logger.warn("Failed to set up memory balloon stats period."
+ e.getMessage());
+ } catch (final Exception e) {
Review Comment:
@DaanHoogland we are trying to read many other parameters in that parser. so
there are chances of other errors such as NPEs, cast errors. While discussing
with Wei several other found in IDE, so thought a common exception could catch
it and warn the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
