DaanHoogland commented on code in PR #6863:
URL: https://github.com/apache/cloudstack/pull/6863#discussion_r1352235962


##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ResetVMPasswordCmd.java:
##########
@@ -56,8 +57,7 @@ public class ResetVMPasswordCmd extends BaseAsyncCmd 
implements UserCmd {
             required=true, description="The ID of the virtual machine")
     private Long id;
 
-    // unexposed parameter needed for serializing/deserializing the command
-    @Parameter(name=ApiConstants.PASSWORD, type=CommandType.STRING, 
expose=false)
+    @Parameter(name=ApiConstants.PASSWORD, type=CommandType.STRING, 
description="The new password of the virtual machine. If null, a random 
password will be generated for the VM.")

Review Comment:
   yes makes sense 
   ```suggestion
       @Parameter(name=ApiConstants.PASSWORD, type=CommandType.STRING, 
description="The new password of the virtual machine. If null, a random 
password will be generated for the VM.", since="4.19.0")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to