DaanHoogland commented on PR #8062: URL: https://github.com/apache/cloudstack/pull/8062#issuecomment-1757099306
code looks ok, but not sure about the consequences. also I don't get this description line @rohityadavcloud : > This removes the conditional logic where comment notest to remove it after PR #5297 is merged that is applicable for ACS 4.18+. especially the `where comment notest to remove` I suppose there is a typo in that line, but I can't firgure it out. > The proposal LGTM, we would only have to validate why creating volume snapshot from VM snapshot is not working. @GutoVeronezi , is that pertinent to this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
