DaanHoogland commented on PR #7386: URL: https://github.com/apache/cloudstack/pull/7386#issuecomment-1759616648
> @shwstppr @DaanHoogland > > code lgtm However, this has only impact on the domain-scope shared networks. > > I think we could add the field to the interface ControlledEntityResponse, and expose domainpath to all entities. https://github.com/apache/cloudstack/blob/main/api/src/main/java/org/apache/cloudstack/api/response/ControlledEntityResponse.java I see your point @weizhouapache : ``` localcloud) 🐱 > list networks filter=name,type,domainpath { "count": 2, "network": [ { "name": "bla", "type": "Isolated" }, { "domainpath": "ROOT", "name": "sla", "type": "Shared" } ] } ``` should for this refuse the PR as is or can we merge and create follow up (an) issue(s)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
