Pearl1594 commented on code in PR #8059:
URL: https://github.com/apache/cloudstack/pull/8059#discussion_r1357061624
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxGuestNetworkGuru.java:
##########
@@ -265,20 +275,22 @@ public void commitMigration(NicProfile nic, Network
network, VirtualMachineProfi
}
private void createNsxSegment(NetworkVO networkVO, DataCenter zone) {
- String vpcName = null;
- if (nonNull(networkVO.getVpcId())) {
- VpcVO vpc = _vpcDao.findById(networkVO.getVpcId());
- if (isNull(vpc)) {
- throw new CloudRuntimeException(String.format("Failed to find
VPC network with id: %s", networkVO.getVpcId()));
- }
- vpcName = vpc.getName();
+ VpcVO vpc = _vpcDao.findById(networkVO.getVpcId());
+ if (isNull(vpc)) {
+ throw new CloudRuntimeException(String.format("Failed to find VPC
network with id: %s", networkVO.getVpcId()));
Review Comment:
This refactor may not be required. The idea of it being the way it was
previously written was that isolated networks could also be created as
segments, and they would be connected to tier0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
