DaanHoogland commented on code in PR #8081:
URL: https://github.com/apache/cloudstack/pull/8081#discussion_r1358043261
##########
api/src/test/java/com/cloud/agent/api/storage/OVFHelperTest.java:
##########
@@ -270,9 +270,9 @@ public class OVFHelperTest {
private String eulaSections =
"<VirtualSystem xmlns=\"http://schemas.dmtf.org/ovf/envelope/1\";
xmlns:cim=\"http://schemas.dmtf.org/wbem/wscim/1/common\";
xmlns:ovf=\"http://schemas.dmtf.org/ovf/envelope/1\";
xmlns:rasd=\"http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_ResourceAllocationSettingData\";
xmlns:vmw=\"http://www.vmware.com/schema/ovf\";
xmlns:vssd=\"http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_VirtualSystemSettingData\";
xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\";>\n" +
- "<EulaSection>\n" +
- " <Info>end-user license agreement</Info>\n" +
- " <License>END USER LICENSE AGREEMENT\n" +
+ "<ovf:EulaSection>\n" +
Review Comment:
in fact, it could be `<any string>:EulaSection`, but I guess that one is
covered. I agree we should add the non-prefixed case in the tests somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
