DaanHoogland commented on code in PR #8085:
URL: https://github.com/apache/cloudstack/pull/8085#discussion_r1358052528
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -1460,6 +1469,11 @@ public void orchestrateStart(final String vmUuid, final
Map<VirtualMachineProfil
}
}
+ private boolean checkThatAllVolumesAreAllocated(long vmId) {
Review Comment:
or
```suggestion
private boolean allVolumesAreAllocatedFor(long vmId) {
```
a boolean method starting with `check...()` seems off a bit. I would expect
an exception for those `check..`-methods .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
