DaanHoogland commented on code in PR #8067:
URL: https://github.com/apache/cloudstack/pull/8067#discussion_r1366807155
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -254,6 +256,7 @@ public KVMPhysicalDisk createPhysicalDisk(String name,
KVMStoragePool pool, Qemu
throw new CloudRuntimeException("Linstor: viewResources didn't
return resources or volumes.");
}
} catch (ApiException apiEx) {
+ s_logger.error("Linstor.createPhysicalDisk: ApiException: " +
apiEx.getBestMessage());
Review Comment:
String.format?
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -214,6 +215,7 @@ private void makeResourceAvailable(DevelopersApi api,
String rscName, boolean di
public KVMPhysicalDisk createPhysicalDisk(String name, KVMStoragePool
pool, QemuImg.PhysicalDiskFormat format,
Storage.ProvisioningType
provisioningType, long size, byte[] passphrase)
{
+ s_logger.debug("Linstor.createPhysicalDisk: " + name + ";" + format);
Review Comment:
use `String.format()`?
```suggestion
s_logger.debug(String.format("Linstor.createPhysicalDisk: %s;%s",
name, format));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
