itsayushpandey commented on code in PR #7712:
URL: https://github.com/apache/cloudstack/pull/7712#discussion_r1375576970
##########
ui/src/views/compute/wizard/MultiNetworkSelection.vue:
##########
@@ -49,7 +49,8 @@
v-for="network in validNetworks[record.id]"
:key="network.id"
:label="network.displaytext + (network.broadcasturi ? ' (' +
network.broadcasturi + ')' : '')">
- {{ network.displaytext + (network.broadcasturi ? ' (' +
network.broadcasturi + ')' : '') }}
+ <div v-if="this.hypervisor === 'KVM'">{{ network.displaytext +
' - ' + (network.id.slice(0,8)) }}</div>
Review Comment:
Sure, I can create a separate method for generating this string?
Context: This is the label for network name in selection dropdown. Since
displaytext can be non-unique, I added 8 characters of the UUID for
differentiating in case of KVM. For VMWare we had broadcast URI from Vlan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
