rohityadavcloud commented on code in PR #8151: URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1375784587
########## api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java: ########## @@ -27,14 +27,13 @@ import org.apache.cloudstack.api.Parameter; import org.apache.cloudstack.api.response.ListResponse; import org.apache.cloudstack.api.response.PhysicalNetworkResponse; -import org.apache.cloudstack.api.response.ProviderResponse; import org.apache.cloudstack.api.response.TrafficTypeResponse; import com.cloud.network.PhysicalNetworkTrafficType; import com.cloud.user.Account; import com.cloud.utils.Pair; -@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = ProviderResponse.class, since = "3.0.0", +@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = TrafficTypeResponse.class, since = "3.0.0", Review Comment: All that was needed was to add some new keys in the response; if we're changing response object we must ensure the resultant response has keys that are superset of original response. I would run a list API call for before and after the fix to compare. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
