madhukar93 commented on code in PR #8151: URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1380417411
########## api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java: ########## @@ -27,14 +27,13 @@ import org.apache.cloudstack.api.Parameter; import org.apache.cloudstack.api.response.ListResponse; import org.apache.cloudstack.api.response.PhysicalNetworkResponse; -import org.apache.cloudstack.api.response.ProviderResponse; import org.apache.cloudstack.api.response.TrafficTypeResponse; import com.cloud.network.PhysicalNetworkTrafficType; import com.cloud.user.Account; import com.cloud.utils.Pair; -@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = ProviderResponse.class, since = "3.0.0", +@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = TrafficTypeResponse.class, since = "3.0.0", Review Comment: besides the functional test, what kind of tests are required to ensure backward compatibility? @rohityadavcloud you mentioned making the response a superset of new and existing fields, confirming if that is required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
