DaanHoogland commented on code in PR #8202:
URL: https://github.com/apache/cloudstack/pull/8202#discussion_r1392166258
##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -1651,6 +1651,16 @@ protected Pair<Map<Volume, List<StoragePool>>,
List<Volume>> findSuitablePoolsFo
for (VolumeVO toBeCreated : volumesTobeCreated) {
s_logger.debug("Checking suitable pools for volume (Id, Type): ("
+ toBeCreated.getId() + "," + toBeCreated.getVolumeType().name() + ")");
+ if (toBeCreated.getState() == Volume.State.Allocated &&
toBeCreated.getPoolId() != null) {
+ toBeCreated.setPoolId(null);
+ if (!_volsDao.update(toBeCreated.getId(), toBeCreated)) {
+ throw new CloudRuntimeException(String.format("Error
updating volume [%s] to clear pool Id.", toBeCreated.getId()));
+ }
+ if (s_logger.isDebugEnabled()) {
+ String msg = String.format("Setting pool_id to NULL for
volume id=%s as it is in Allocated state", toBeCreated.getId());
+ s_logger.debug(msg);
+ }
+ }
Review Comment:
this can be moved to a separate method and tested (separately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
