hsato03 opened a new pull request, #8254:
URL: https://github.com/apache/cloudstack/pull/8254

   ### Description
   
   The KVM Agent has the `hypervisor.uri` configuration to define the 
connection with Libvirt; however, this property is ignored and a hardcoded 
value is used in many parts of the code.
   
   This PR intends to prioritize the `hypervisor.uri` property in Libvirt 
connections and use the hypervisor default URI only when this configuration is 
not defined.
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   I followed the same steps from `How did you try to break this feature...` 
and verified that the host was only using the URI defined in the 
`hypervisor.uri` property.
   
   
   #### How did you try to break this feature and the system with this change?
   
   1. Add the `hypervisor.uri` property to a host's agent.properties, 
`hypervisor.uri=qemu:///session` for example;
   2. Check the agent logs;
   3. Although the `hypervisor.uri` property is defined, the agent is still 
using the hypervisor default URI in many connections;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to