weizhouapache commented on PR #8135: URL: https://github.com/apache/cloudstack/pull/8135#issuecomment-1832158929
> @DaanHoogland @weizhouapache I suggest we go ahead with this PR for 4.18 branch and then in main create a PR, > > * updating the params description that they are returned only when VM deployed from ISO or any other valid case. > * use listVirtualMachines API details param to return volume details @shwstppr I agree with the changes you mentioned. AFAIK, `diskofferingid` and `diskofferingname` are the info of ROOT disk in 4.16.x. However, `disk_offering_id` has been removed from `vm_instance` table in #5008 , which leads to a bit complicated to set the value, but should be feasible. that's say, this PR needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
