slavkap commented on code in PR #7889:
URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1411973804
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1620,7 +1623,8 @@ protected void runInContext() {
for (StoragePoolVO pool : pools) {
List<VolumeVO> volumes =
_volsDao.findByPoolId(pool.getId(), null);
for (VolumeVO volume : volumes) {
- if (volume.getFormat() != ImageFormat.QCOW2 &&
volume.getFormat() != ImageFormat.VHD && volume.getFormat() != ImageFormat.OVA
&& (volume.getFormat() != ImageFormat.RAW || pool.getPoolType() !=
Storage.StoragePoolType.PowerFlex)) {
+ if (!List.of(ImageFormat.QCOW2, ImageFormat.VHD,
ImageFormat.OVA).contains(volume.getFormat()) &&
Review Comment:
@rg9975, can you add the RAW format to the list?
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -205,15 +205,15 @@ protected Answer copyObject(DataObject srcData,
DataObject destData, Host destHo
", uuid: " + cacheUuid + ")");
cacheMgr.deleteCacheObject(srcForCopy);
} else {
- s_logger.debug("Decrease reference count of " +
cacheType +
+ if (s_logger.isTraceEnabled())
s_logger.trace("Decrease reference count of " + cacheType +
" cache(id: " + cacheId + ", uuid: " +
cacheUuid + ")");
cacheMgr.releaseCacheObject(srcForCopy);
}
}
}
return answer;
} catch (Exception e) {
- s_logger.debug("copy object failed: ", e);
+ if (s_logger.isTraceEnabled()) s_logger.trace("copy object failed:
", e);
Review Comment:
I think it's better to leave the logging level to `DEBUG`. It is easier when
investigating any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
