Pearl1594 commented on code in PR #8189:
URL: https://github.com/apache/cloudstack/pull/8189#discussion_r1419492806
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -338,10 +340,15 @@ public Map<String, List<String>> getServiceProviders() {
private void getServiceProviderMapForNsx(Map<String, List<String>>
serviceProviderMap) {
String routerProvider = Boolean.TRUE.equals(getForVpc()) ?
VirtualRouterProvider.Type.VPCVirtualRouter.name() :
VirtualRouterProvider.Type.VirtualRouter.name();
- List<String> unsupportedServices = List.of("Vpn", "SecurityGroup",
"Connectivity",
- "Gateway", "Firewall", "BaremetalPxeService");
+ List<String> unsupportedServices = new ArrayList<>(List.of("Vpn",
"SecurityGroup", "Connectivity",
Review Comment:
To create a service map for NSX - coz we predetermine the services NSX
offering will offer.. and we want to filter out other services not supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
