sureshanaparti commented on code in PR #8385:
URL: https://github.com/apache/cloudstack/pull/8385#discussion_r1434726611
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2350,7 +2350,7 @@ public boolean finalizeCommandsOnStart(final Commands
cmds, final VirtualMachine
if (reprogramGuestNtwks) {
finalizeIpAssocForNetwork(cmds, router, provider,
guestNetworkId, null);
finalizeNetworkRulesForNetwork(cmds, router, provider,
guestNetworkId);
- finalizeMonitorService(cmds, profile, router, provider,
guestNetworkId, true);
+ finalizeMonitorService(cmds, profile, router, provider,
guestNetworkId, true, getRouterHealthChecksConfig(router));
Review Comment:
```suggestion
finalizeMonitorService(cmds, profile, router, provider,
guestNetworkId, true, routerHealthCheckConfig);
```
@phsm seems it is called in loop here, so better populate the map
_routerHealthCheckConfig_ outside loop and pass here.
at line #2344 _Map<String, String> routerHealthCheckConfig =
getRouterHealthChecksConfig(router);_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
