DaanHoogland commented on code in PR #8411:
URL: https://github.com/apache/cloudstack/pull/8411#discussion_r1437608321
##########
pom.xml:
##########
@@ -55,7 +55,7 @@
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<!-- Build properties -->
- <cs.jdk.version>11</cs.jdk.version>
+ <cs.jdk.version>17</cs.jdk.version>
Review Comment:
if we do 21 we have more time to think of our sins.
```suggestion
<cs.jdk.version>21</cs.jdk.version>
```
##########
engine/schema/pom.xml:
##########
@@ -61,9 +61,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.gmaven</groupId>
- <artifactId>gmaven-plugin</artifactId>
- <version>1.5</version>
+ <groupId>org.codehaus.gmavenplus</groupId>
+ <artifactId>gmavenplus-plugin</artifactId>
+ <version>3.0.2</version>
Review Comment:
can this come from the parent pom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
