anniejili commented on PR #8484: URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1885341225
> @anniejili , it makes function sense what you are trying to do. I have some requests though. > > * can you make methods for the new code, especially try to avoid having nested try-catch blocks in a single method? @DaanHoogland Hi Dahn, Thank you for reviewing my code. As far as I can tell, there is no nested try-catch introduced by this change. Can you please double check? > * as @harikrishna-patnala requested, please remove commented code? We have source control and can always get the code back if we need to. Done. Thank you @harikrishna-patnala! > * you submitted and closed another PR for a similar attempt. There is no reason to open a new one, you can push --force to the same branch to update the PR with your new method of implementation. This will aid in keeping track of discussions on the subject. > My bad, will make sure it won't happen next time. > That all said, thanks you for you effort and welcome ;) . once again it makes total sense and also seems to do what you suggested on the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
