shwstppr commented on code in PR #8490:
URL: https://github.com/apache/cloudstack/pull/8490#discussion_r1448346837
##########
ui/src/views/tools/ManageInstances.vue:
##########
@@ -322,8 +323,8 @@
<a-col v-if="!isDiskImport" :md="24" :lg="(!isMigrateFromVmware &&
showManagedInstances) ? 12 : 24">
<a-card class="instances-card">
<template #title>
- {{ $t('label.unmanaged.instances') }}
- <a-tooltip :title="$t('message.instances.unmanaged')">
+ {{ (isMigrateFromVmware && vmwareVcenterType === 'existing')
? $t('label.instances') : $t('label.unmanaged.instances') }}
+ <a-tooltip :title="(isMigrateFromVmware && vmwareVcenterType
=== 'existing') ? $t('message.instances.migrate.vmware') :
$t('message.instances.unmanaged')">
Review Comment:
@DaanHoogland current change allows showing `Instances` label only when the
vCenter is an existing one. External vCenter will always considered to have
unmanaged instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
