nvazquez commented on code in PR #8504:
URL: https://github.com/apache/cloudstack/pull/8504#discussion_r1452379959
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -428,6 +437,18 @@ protected void validateNetworkAcl(NetworkACL acl) {
}
}
+ private void validateNsxConstraints(Long vpcId, Integer icpmType) {
+ VpcVO vpc = _vpcDao.findById(vpcId);
+ final DataCenter dc = _entityMgr.findById(DataCenter.class,
vpc.getZoneId());
+ final NsxProviderVO nsxProvider =
nsxProviderDao.findByZoneId(dc.getId());
+ if (Objects.isNull(nsxProvider)) {
+ return;
+ }
+ if (icpmType == -1) {
+ throw new InvalidParameterValueException("Passing -1 for ICMP type
is not supported for NSX enabled zones");
Review Comment:
Minor nit - we can also log this and throw the exception with the same
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
