winterhazel opened a new pull request, #8511:
URL: https://github.com/apache/cloudstack/pull/8511

   ### Description
   
   The class `LibvirtComputingResource` does not provide enough information 
about what is happening during the metrics collection process and contains some 
logs with formatting issues. 
   
   This PR refactors the metrics collection process while adding logs, and 
fixes some logs that contained problems.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   I manually verified the logs in the agent. Regarding the refactoring, I 
adapted the unit tests to a commit before the refactoring and verified that the 
metrics had the same values before and after the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to