vishesh92 opened a new pull request, #8545: URL: https://github.com/apache/cloudstack/pull/8545
### Description We discovered this issue in one of our envs where a VM was running on the host but the state of the VM in the host was Stopped. Ideally power reports should have fixed this, but it didn't. This PR adds additional checks to ensure that when: * VM is in stopped state and power report is powerOn * VM is in running state and power report is powerOff It sends an update (publishes a message on Topic `VM_POWER_STATE`). The subscriber on this topic transits the VM as per the state & powerstate. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> I wasn't able to reproduce the issue. But updating the entry for vm_instance in the database helps. 1. Launch a VM and ensure it's running. 2. Run the below update query for the instance ```sql UPDATE vm_instance SET state = 'Stopped', power_state_update_count = 3 where id = 12345; ``` It should switch back to 'Running' after next power state update, but it doesn't happen. <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> After these changes, I was not able to reproduce the issue by running update query mentioned above. #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
