sureshanaparti commented on code in PR #8575:
URL: https://github.com/apache/cloudstack/pull/8575#discussion_r1472904889
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java:
##########
@@ -846,6 +791,42 @@ public void copyAsync(DataObject srcData, DataObject
dstData, AsyncCompletionCal
callback.complete(res);
}
+ private Answer createVolumeSnapshot(StorageSubSystemCommand cmd, Long
size, SpConnectionDesc conn,
+ String volName, TemplateObjectTO dstTO) {
+ Answer answer;
+ SpApiResponse resp2 = StorPoolUtil.volumeSnapshot(volName,
dstTO.getUuid(), null, "template", null, conn);
Review Comment:
```suggestion
SpApiResponse resp = StorPoolUtil.volumeSnapshot(volName,
dstTO.getUuid(), null, "template", null, conn);
```
(or) spApiResponse as appropriate
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java:
##########
@@ -846,6 +791,42 @@ public void copyAsync(DataObject srcData, DataObject
dstData, AsyncCompletionCal
callback.complete(res);
}
+ private Answer createVolumeSnapshot(StorageSubSystemCommand cmd, Long
size, SpConnectionDesc conn,
+ String volName, TemplateObjectTO dstTO) {
+ Answer answer;
+ SpApiResponse resp2 = StorPoolUtil.volumeSnapshot(volName,
dstTO.getUuid(), null, "template", null, conn);
Review Comment:
```suggestion
SpApiResponse resp = StorPoolUtil.volumeSnapshot(volName,
dstTO.getUuid(), null, "template", null, conn);
```
(or) `spApiResponse` as appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
