weizhouapache commented on code in PR #8599:
URL: https://github.com/apache/cloudstack/pull/8599#discussion_r1479530106


##########
server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java:
##########
@@ -294,7 +295,23 @@ public boolean finalizeVirtualMachineProfile(final 
VirtualMachineProfile profile
             }
         }
 
-        return super.finalizeVirtualMachineProfile(profile, dest, context);
+        super.finalizeVirtualMachineProfile(profile, dest, context);

Review Comment:
   yes @DaanHoogland 
   
   it always return true in the parent class, 
   
   
https://github.com/apache/cloudstack/blob/37bb24f29e02480488312f1a0c8965c3543651d8/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L2153
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to