DaanHoogland commented on code in PR #8611:
URL: https://github.com/apache/cloudstack/pull/8611#discussion_r1480038289
##########
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:
##########
@@ -132,9 +131,9 @@ public List<Host> allocateTo(VirtualMachineProfile
vmProfile, DeploymentPlan pla
return new ArrayList<Host>();
}
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Looking for hosts in dc: " + dcId + " pod:" +
podId + " cluster:" + clusterId);
- }
+ String paramAsStringToLog = String.format("zone [%s], pod [%s],
cluster [%s]", dcId, podId, clusterId);
+
+ s_logger.debug(String.format("Looking for hosts in %s.",
paramAsStringToLog));
Review Comment:
I see no reason to remove this guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
