DaanHoogland commented on code in PR #8308:
URL: https://github.com/apache/cloudstack/pull/8308#discussion_r1480180095
##########
server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java:
##########
@@ -1713,9 +1713,9 @@ public void validateNtwkOffForVpc(final NetworkOffering
guestNtwkOff, final List
* ("No redunant router support when network belnogs to VPC"); }
*/
- // 4) Conserve mode should be off
+ // 4) Conserve mode should be off in elder versions
if (guestNtwkOff.isConserveMode()) {
- throw new InvalidParameterValueException("Only networks with
conserve mode Off can belong to VPC");
+ s_logger.info("Creating a network with conserve mode in VPC");
}
Review Comment:
can“t we just delete? (is this info useful?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]