This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-nsx-reorder-acl-rules
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit a1990e51f74a2d72bdecf9763798930ff6e55cf4
Author: Pearl Dsilva <[email protected]>
AuthorDate: Fri Feb 2 10:21:06 2024 -0500

    NSX: fix smoke test failure for ACLs (#9)
---
 server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java 
b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
index d05ead6c143..59e7d441e69 100644
--- a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
+++ b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
@@ -439,6 +439,9 @@ public class NetworkACLServiceImpl extends ManagerBase 
implements NetworkACLServ
     private void validateNsxConstraints(long vpcId, String protocol, Integer 
icmpType,
                                         Integer icmpCode, Integer 
sourcePortStart, Integer sourcePortEnd) {
         VpcVO vpc = _vpcDao.findById(vpcId);
+        if (Objects.isNull(vpc)) {
+            return;
+        }
         final DataCenter dc = _entityMgr.findById(DataCenter.class, 
vpc.getZoneId());
         final NsxProviderVO nsxProvider = 
nsxProviderDao.findByZoneId(dc.getId());
         if (Objects.isNull(nsxProvider)) {

Reply via email to