weizhouapache commented on code in PR #8616:
URL: https://github.com/apache/cloudstack/pull/8616#discussion_r1480372227
##########
engine/schema/src/main/java/com/cloud/network/security/dao/SecurityGroupVMMapDaoImpl.java:
##########
@@ -131,7 +131,7 @@ public List<SecurityGroupVMMapVO> listBySecurityGroup(long
securityGroupId, Stat
SearchCriteria<SecurityGroupVMMapVO> sc =
ListBySecurityGroupAndStates.create();
sc.setParameters("securityGroupId", securityGroupId);
sc.setParameters("states", (Object[])vmStates);
- return listBy(sc, null, true);
Review Comment:
@DaanHoogland
I think so. but it requires several lines of changes in `GenericDaoBase.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
