shwstppr commented on code in PR #8362:
URL: https://github.com/apache/cloudstack/pull/8362#discussion_r1490013340
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -8487,10 +8536,15 @@ public Boolean getDestroyRootVolumeOnVmDestruction(Long
domainId){
return DestroyRootVolumeOnVmDestruction.valueIn(domainId);
}
- private void setVncPasswordForKvmIfAvailable(Map<String, String>
customParameters, UserVmVO vm){
+ private void setVncPasswordForKvmIfAvailable(Map<String, String>
customParameters, UserVmVO vm) {
if (customParameters.containsKey(VmDetailConstants.KVM_VNC_PASSWORD)
&&
StringUtils.isNotEmpty(customParameters.get(VmDetailConstants.KVM_VNC_PASSWORD)))
{
vm.setVncPassword(customParameters.get(VmDetailConstants.KVM_VNC_PASSWORD));
}
}
+
+ @Override
+ public Map<Long, Boolean> getDiskOfferingSuitabilityForVm(long vmId,
List<Long> diskOfferingIds) {
+ return _itMgr.getDiskOfferingSuitabilityForVm(vmId, diskOfferingIds);
Review Comment:
StoragePoolAllocators were not accessible in `UserVmManagerImpl` so it calls
VitualMachineManager. I'll check using VirtualMachineManager itself in
ApiDBUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
