GutoVeronezi commented on code in PR #8354:
URL: https://github.com/apache/cloudstack/pull/8354#discussion_r1490104361
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2681,18 +2681,11 @@ protected void finalizeIpAssocForNetwork(final Commands
cmds, final VirtualRoute
}
}
- protected ArrayList<? extends PublicIpAddress> getPublicIpsToApply(final
VirtualRouter router, final Provider provider, final Long guestNetworkId,
+ protected ArrayList<? extends PublicIpAddress> getPublicIpsToApply(final
Provider provider, final Long guestNetworkId,
final com.cloud.network.IpAddress.State... skipInStates) {
- final long ownerId = router.getAccountId();
final List<? extends IpAddress> userIps;
- final Network guestNetwork = _networkDao.findById(guestNetworkId);
- if (guestNetwork.getGuestType() == GuestType.Shared) {
- // ignore the account id for the shared network
- userIps =
_networkModel.listPublicIpsAssignedToGuestNtwk(guestNetworkId, null);
- } else {
- userIps = _networkModel.listPublicIpsAssignedToGuestNtwk(ownerId,
guestNetworkId, null);
- }
+ userIps =
_networkModel.listPublicIpsAssignedToGuestNtwk(guestNetworkId, null);
Review Comment:
```suggestion
final List<? extends IpAddress> userIps =
_networkModel.listPublicIpsAssignedToGuestNtwk(guestNetworkId, null);
```
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2681,18 +2681,11 @@ protected void finalizeIpAssocForNetwork(final Commands
cmds, final VirtualRoute
}
}
- protected ArrayList<? extends PublicIpAddress> getPublicIpsToApply(final
VirtualRouter router, final Provider provider, final Long guestNetworkId,
+ protected ArrayList<? extends PublicIpAddress> getPublicIpsToApply(final
Provider provider, final Long guestNetworkId,
final com.cloud.network.IpAddress.State... skipInStates) {
- final long ownerId = router.getAccountId();
final List<? extends IpAddress> userIps;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
