DaanHoogland commented on code in PR #8306:
URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1490711474
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java:
##########
@@ -443,9 +451,14 @@ public List<StoragePoolVO> findDisabledPoolsByScope(long
dcId, Long podId, Long
@Override
public List<StoragePoolVO> findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule) {
+ return findLocalStoragePoolsByTags(dcId, podId, clusterId, tags,
validateTagRule, null);
+ }
+
+ @Override
+ public List<StoragePoolVO> findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule, String keyword) {
List<StoragePoolVO> storagePools = null;
if (tags == null || tags.length == 0) {
Review Comment:
@GaOrtiga will you apply this sugestion (ready-for-merge otherwise)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
