sureshanaparti commented on code in PR #8653:
URL: https://github.com/apache/cloudstack/pull/8653#discussion_r1490932358
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java:
##########
@@ -958,9 +954,12 @@ private Answer copyTemplate(DataObject srcData, DataObject
dstData) {
}
else {
answer = new Answer(cmd, false, "Unable to get matching
Linstor endpoint.");
+ deleteResourceDefinition(pool, rscName);
}
} catch (ApiException exc) {
s_logger.error("copy template failed: ", exc);
+ s_logger.info(String.format("deleting failed template resource:
%s", rscName));
Review Comment:
can move this log to `deleteResourceDefinition()` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
