weizhouapache commented on code in PR #8621:
URL: https://github.com/apache/cloudstack/pull/8621#discussion_r1494221723
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -2715,6 +2719,12 @@ public Pair<String, String> getNetworkIp4Dns(final
Network network, final DataCe
if (StringUtils.isNotBlank(network.getDns1())) {
return new Pair<>(network.getDns1(), network.getDns2());
}
+ if (network.getVpcId() != null) {
+ Vpc vpc = vpcDao.findById(network.getVpcId());
Review Comment:
this is similar as the network DNSs (the Dns2 can be null)
```
if (StringUtils.isNotBlank(network.getDns1())) {
return new Pair<>(network.getDns1(), network.getDns2());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
