DaanHoogland commented on code in PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#discussion_r1492852861
##########
engine/schema/pom.xml:
##########
@@ -101,8 +101,10 @@
for (template in templateList) {
def data = lines.findAll {
it.contains(template) }
if (data != null) {
- def hypervisor =
template.tokenize('-')[-1]
- pom.properties["$hypervisor" +
".checksum"] = data[0].tokenize(' ')[0]
+ if (data.size() > 0) {
Review Comment:
these can be one compound condition
##########
pom.xml:
##########
@@ -50,7 +50,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<project.systemvm.template.location>https://download.cloudstack.org/systemvm</project.systemvm.template.location>
-
<project.systemvm.template.version>4.19.0.0</project.systemvm.template.version>
+
<project.systemvm.template.version>4.20.0.0</project.systemvm.template.version>
Review Comment:
maybe (pending vote) should we go for
```suggestion
<project.systemvm.template.version>20.0.0</project.systemvm.template.version>
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
