DaanHoogland commented on code in PR #8714:
URL: https://github.com/apache/cloudstack/pull/8714#discussion_r1505510983
##########
agent/src/main/java/com/cloud/agent/Agent.java:
##########
@@ -286,22 +287,22 @@ public void start() {
try {
_connection.start();
} catch (final NioConnectionException e) {
- logger.warn("NIO Connection Exception " + e);
+ logger.warn("NIO Connection Exception {}", e);
Review Comment:
a `warn()` with an exception and then an `info()` with a more generic
message. I think we can improve more here.
i.e:
- warn with `e.getLocalizedMessage()` and
- remove the `info()` which is of lesser level anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
