KlausDornsbach commented on code in PR #8728:
URL: https://github.com/apache/cloudstack/pull/8728#discussion_r1507801056
##########
api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java:
##########
@@ -119,8 +120,7 @@ protected OVFPropertyTO createOVFPropertyFromNode(Node
node, int index, String c
boolean password = StringUtils.isNotBlank(passStr) &&
passStr.equalsIgnoreCase("true");
String label = ovfParser.getChildNodeValue(node, "Label");
String description = ovfParser.getChildNodeValue(node, "Description");
- logger.debug("Creating OVF property index " + index + (category ==
null ? "" : " for category " + category)
- + " with key = " + key);
+ logger.debug("Creating OVF property index {} {} with key = {}", index,
(category == null ? "" : " for category " + category), key);
Review Comment:
should I use lambdas even when there is no big structure being read from
memory or costly function being called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
