sureshanaparti commented on code in PR #8755:
URL: https://github.com/apache/cloudstack/pull/8755#discussion_r1519235569
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -2324,7 +2339,7 @@ private void validateVolumeResizeWithSize(VolumeVO
volume, long currentSize, Lon
* the actual disk size.
*/
if (currentSize > newSize) {
- if (volume != null &&
ImageFormat.QCOW2.equals(volume.getFormat()) &&
!Volume.State.Allocated.equals(volume.getState())) {
+ if (volume != null &&
ImageFormat.QCOW2.equals(volume.getFormat()) &&
!Volume.State.Allocated.equals(volume.getState()) &&
!StoragePoolType.StorPool.equals(volume.getPoolType())) {
Review Comment:
agree @slavkap , maybe these hard-coded checks have to be fixed at some
point of time with proper testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
