rohityadavcloud commented on code in PR #8737:
URL: https://github.com/apache/cloudstack/pull/8737#discussion_r1533432581
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to41910.java:
##########
@@ -61,6 +66,25 @@ public InputStream[] getCleanupScripts() {
throw new CloudRuntimeException("Unable to find " + scriptFile);
}
- return new InputStream[] {script};
+ return new InputStream[]{script};
+ }
+
+ private void addIndexes(Connection conn) {
+ DbUpgradeUtils.addIndexIfNeeded(conn, "vm_stats", "vm_id");
+ }
+
+ @Override
+ public void updateSystemVmTemplates(Connection conn) {
+ LOG.debug("Updating System Vm template IDs");
+ initSystemVmTemplateRegistration();
+ try {
+ systemVmTemplateRegistration.updateSystemVmTemplates(conn);
+ } catch (Exception e) {
+ throw new CloudRuntimeException("Failed to find / register
SystemVM template(s)");
+ }
+ }
+
+ private void initSystemVmTemplateRegistration() {
+ systemVmTemplateRegistration = new SystemVmTemplateRegistration("");
Review Comment:
These are common pattern of changes, without this CloudStack doesn't
check/auto-configure/install/upgrade systemvmtemplates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
