weizhouapache commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2018221399
> You outdid yourself in delivering good code again @weizhouapache , my compliments. As a single remark, I would try to disect `LibvirtGetVolumesOnStorageCommandWrapper.execute(final GetVolumesOnStorageCommand command, final LibvirtComputingResource libvirtComputingResource)` some more. > > remarks are not blocking. thanks @DaanHoogland for review `LibvirtGetVolumesOnStorageCommandWrapper` is refactored as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
