weizhouapache commented on code in PR #8809:
URL: https://github.com/apache/cloudstack/pull/8809#discussion_r1542124211
##########
server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java:
##########
@@ -36,6 +36,9 @@ public interface ConsoleProxyManager extends Manager,
ConsoleProxyService {
String ALERT_SUBJECT = "proxy-alert";
String CERTIFICATE_NAME = "CPVMCertificate";
+ ConfigKey<Boolean> ConsoleProxySslEnabled = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Boolean.class,
"consoleproxy.sslEnabled", "false",
Review Comment:
> ```suggestion
> ConfigKey<Boolean> ConsoleProxySslEnabled = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Boolean.class,
"consoleproxy.ssl.enabled", "false",
> ```
@hsato03
There is already a global configuration named `consoleproxy.sslEnabled`
This PR does not include the renaming of the configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
