DaanHoogland commented on code in PR #8765:
URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1551329091
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(final
Commands cmds, final DomainR
}
}
- final List<LoadBalancerVO> lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ List<LoadBalancerVO> lbs = null;
+ Long vpcId = guestNetwork.getVpcId();
+ if (vpcId != null) {
+ lbs = _loadBalancerDao.listByVpcIdAndScheme(vpcId,
Scheme.Public);
Review Comment:
> @SadiJr if you do not mind, I can create a new PR for it tomorrow
@weizhouapache , would this be an alternative or an addition?
Have you created it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
